kito-cheng marked 6 inline comments as done. kito-cheng added inline comments.
================ Comment at: clang/test/Driver/riscv-cpus.c:86 +// MCPU-ABI-SIFIVE-S21: "-target-feature" "+c" +// MCPU-ABI-SIFIVE-S21: "-target-feature" "+64bit" // MCPU-ABI-SIFIVE-S21: "-target-abi" "lp64" ---------------- MaskRay wrote: > If the two features are adjacent, I suggest you place them one the same line. It's not adjacent after this patch. ================ Comment at: clang/test/Driver/riscv-march-mcpu-mtune.c:30 +// MARCH-RV32IMAFDC: "-target-feature" "+c" +// MARCH-RV32IMAFDC-NOT: "-target-cpu" + ---------------- MaskRay wrote: > This NOT pattern isn't useful as `-target-cpu` has occurred. Thanks for catch this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140693/new/ https://reviews.llvm.org/D140693 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits