bryanpkc added a comment.
Thanks for the patch. I just have some simple suggestions.
================
Comment at: clang/test/Driver/modules-ts.cpp:23
//
-// CHECK-USE: -cc1
+// CHECK-USE: -cc1{{[^[:xdigit:]]}}
// CHECK-USE-SAME: -emit-obj
----------------
An easier-to-understand fix is to simply combine this line and the next:
```
// CHECK-USE: -cc1 {{.*}} -emit-obj
```
================
Comment at: clang/test/OpenMP/driver.c:6
-// CHECK-DEFAULT: -cc1
+// CHECK-DEFAULT: -cc1{{[^[:xdigit:]]}}
// CHECK-DEFAULT-NOT: -fnoopenmp-use-tls
----------------
With `-###` on the command line, a better fix for this is:
```
// CHECK-DEFAULT: "-cc1"
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141886/new/
https://reviews.llvm.org/D141886
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
