thakis added a comment. In D136315#4065426 <https://reviews.llvm.org/D136315#4065426>, @calebzulawski wrote:
> I don't think we necessarily need to revert due to the xcrun quirk since I > think it's harmless, though I can provide a follow up change if necessary. I > just checked Rust's source as a comparison and it appears that for macOS > targets it will always attempt to invoke xcrun regardless of host as well. Needlessly spawning additional processes doesn't seem "harmless" to me. If you can fix quickly, sure, do that. > I could see a macOS cross-compiler environment providing an xcrun > replacement, for example. That's theoretically possible I suppose, but it doesn't exist. No mac cross compiling uses `xcrun`. > The test failures are another issue but I still don't quite understand the > cause. I can investigate a bit more. Which version of macOS are you running? Are you using system python3 or brew python3? I know that system python3 sets SDKROOT by default on macOS 13+ for some reason, so maybe that's related. (The bot runs macOS 13.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
