tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Driver/OffloadBundler.cpp:1063
// in case host bundle name was provided in command line.
- if (!FoundHostBundle && BundlerConfig.HostInputIndex != ~0u)
+ if (!FoundHostBundle && BundlerConfig.HostInputIndex != ~0u &&
!BundlerConfig.AllowMissingBundles)
return createStringError(inconvertibleErrorCode(),
----------------
Nit: My usual pet peeve - too many negations.
`if (!(FoundHostBundle || BundlerConfig.HostInputIndex == ~0u ||
BundlerConfig.AllowMissingBundles)))` is easier to understand, IMO.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142118/new/
https://reviews.llvm.org/D142118
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
