arsenm added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:9552
     F->addFnAttr("uniform-work-group-size", "true");
+  if (IsOpenMPkernel)
+    F->addFnAttr("amdgpu-flat-work-group-size",
----------------
Probably shouldn’t check the language, just it’s a kernel. Also shouldn’t emit 
this if it’s the default 1024. I’ve been trying to cut down on the superfluous 
attribute spam


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142393/new/

https://reviews.llvm.org/D142393

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to