Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In D142196#4074249 <https://reviews.llvm.org/D142196#4074249>, @jansvoboda11 wrote:
> Also I think we should mention this API in our docs, right where the removed > original used to be. Which API docs are you referring to? I'm only aware of the `pp-trace` docs (updated in https://reviews.llvm.org/D125258 for the removal), but I didn't add `FileNotFound` to `pp-trace` because it's more of a hook than a "traceable event" - should I add it nevertheless? ================ Comment at: clang/include/clang/Lex/PPCallbacks.h:87 + /// Callback invoked whenever an inclusion directive results in a + /// file-not-found error. + /// ---------------- jansvoboda11 wrote: > The wording is a bit misleading due to: > ``` > if (SuppressIncludeNotFoundError) > return std::nullopt; > ``` > after invoking this callback. Reading the comment, I assume the diagnostic > has already been issued. Can we tweak this to clarify things? Please let me know if this sounds better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
