tbaeder added inline comments.

================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:727-728
+    this->emitSubOffset(*RT, E);
+  else
+    return false;
+
----------------
aaron.ballman wrote:
> Should this be an early return before we visit anything? Or an assert on the 
> assumption that we should only get here for `+=` and `-=`?
Sure, that would work as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140874/new/

https://reviews.llvm.org/D140874

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to