tbaeder added inline comments.

================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1417-1418
+      assert(!BD->getHoldingVar()); // FIXME
+      if (!this->allocateVariable(BD, BD->getBinding()))
+        return false;
+    }
----------------
aaron.ballman wrote:
> <uncertain>Is this correct? IIRC, the decomposition declaration is its own 
> object, but the bindings themselves are references back to the decomposition 
> declaration object directly and so they're not distinct objects themselves 
> (they're more like aliases).</uncertain>
Is this not reflected in the individual bindings? What does it mean that the 
bindings aren't "distinct objects themselves"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138802/new/

https://reviews.llvm.org/D138802

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to