sgraenitz added inline comments.
================
Comment at: clang/lib/Interpreter/Interpreter.cpp:223
+llvm::Error Interpreter::CreateExecutor() {
+ const clang::TargetInfo &TI =
----------------
argentite wrote:
> sgraenitz wrote:
> > Factoring out this function looks like an independent change. Is it related
> > to the load-library command in any way?
> The `IncrementalExecutor` was being created on the first call to `Execute()`.
> It is created lazily for `-fsyntax-only` support. It holds the Execution
> Engine that we need for loading the library. So we need to be able to create
> it in `getExecutionEngine()` as well because a library can be loaded before
> any code is executed.
Of course, right. I had missed the second use.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141824/new/
https://reviews.llvm.org/D141824
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
