iana added a comment. In D140250#4077974 <https://reviews.llvm.org/D140250#4077974>, @iana wrote:
> In D140250#4077956 <https://reviews.llvm.org/D140250#4077956>, @aaron.ballman > wrote: > >> In D140250#4077826 <https://reviews.llvm.org/D140250#4077826>, @iana wrote: >> >>> In D140250#4076851 <https://reviews.llvm.org/D140250#4076851>, >>> @aaron.ballman wrote: >>> >>>> I'd expect there to be a test under `clang/test/Headers/` showing that >>>> this new header works as expected. >>> >>> It's covered pretty well by stddefneeds.cpp already. I can add a new one if >>> you want, but it'd pretty much be a copy/paste >> >> I was thinking of one similar to that but includes the new header and *not* >> stddef.h to demonstrate that this works entirely standalone. WDYT? > > Yeah ok sure Added, let me know if it's missing anything please! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
