benlangmuir created this revision. benlangmuir added a reviewer: tstellar. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
The check for "no SOURCE_DATE_EPOCH" wasn't especially interesting, and I am not aware of a _portable_ way to unset and environment variable in a lit test. So remove it since it can fail if the build environment has SOURCE_DATE_EPOCH set globally. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142511 Files: clang/test/Driver/SOURCE_DATE_EPOCH.c Index: clang/test/Driver/SOURCE_DATE_EPOCH.c =================================================================== --- clang/test/Driver/SOURCE_DATE_EPOCH.c +++ clang/test/Driver/SOURCE_DATE_EPOCH.c @@ -1,5 +1,2 @@ -// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH -// NO_EPOCH-NOT: "-source-date-epoch" - // RUN: env SOURCE_DATE_EPOCH=123 %clang -E %s -### 2>&1 | FileCheck %s // CHECK: "-source-date-epoch" "123"
Index: clang/test/Driver/SOURCE_DATE_EPOCH.c =================================================================== --- clang/test/Driver/SOURCE_DATE_EPOCH.c +++ clang/test/Driver/SOURCE_DATE_EPOCH.c @@ -1,5 +1,2 @@ -// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH -// NO_EPOCH-NOT: "-source-date-epoch" - // RUN: env SOURCE_DATE_EPOCH=123 %clang -E %s -### 2>&1 | FileCheck %s // CHECK: "-source-date-epoch" "123"
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
