pratlucas marked an inline comment as done. pratlucas added inline comments.
================ Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456 + std::optional<AArch64::ExtensionInfo> Extension = + AArch64::parseArchExtension(ArchExt); + if (!Extension) ---------------- tmatheson wrote: > I think we still need to test getDefaultExtensions, unless we're deleting it. D142540 deletes it in favor of using the information in `CpuInfo` and `ArchInfo`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142539/new/ https://reviews.llvm.org/D142539 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
