Michael137 added inline comments.

================
Comment at: clang/lib/AST/TypePrinter.cpp:2031
+    if (args_expr->isValueDependent() || 
!args_expr->isIntegerConstantExpr(Ctx))
+      return false;
+
----------------
aprantl wrote:
> Just for my own education: what's an example for a value-dependent constant 
> integer expression?
There is no such case, we're checking it here because it's a pre-condition for 
`isIntegerConstantExpr`. But we can have value-dependent expressions here like 
`sizeof(T)` we so can't unconditionally call `isIntegerConstantExpr`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142632/new/

https://reviews.llvm.org/D142632

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to