nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/FindTarget.cpp:720 + // Pick up the name via VisitNamedDecl + Base::VisitTemplateTypeParmDecl(D); + } ---------------- Am I using the API correctly here? It's a bit weird that `ConstDeclVisitor` would work differently from `RecursiveASTVisitor` in that VisitXXX methods for super-classes are not automatically called Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits