royjacobson added inline comments.

================
Comment at: clang/docs/ReleaseNotes.rst:16
      Release notes for previous releases can be found on
-     `the Download Page <https://releases.llvm.org/download.html>`_.
+     `the Releases Page <https://llvm.org/releases>`_.
 
----------------
aaron.ballman wrote:
> Are you planning to merge the changes in generic text over to the trunk once 
> this lands?
Yeah, absolutely!


================
Comment at: clang/docs/ReleaseNotes.rst:43
+  conforming GNU extensions. Projects incompatible with C++17 can add
+  ``-std=gnu++14`` to their build settings to restore the previous behaviour.
 
----------------
aaron.ballman wrote:
> Do we want to mention that this may also impact build-time performance of 
> projects relying on the default language standard mode, because C++17 pulls 
> in a lot more compile-time-intensive APIs like constexpr and more template 
> metaprogramming?
I agree this change is annoying and has real life impact - I'm not trying to 
minimize it - but I think newer language versions bring enough benefits that we 
shouldn't warn users about using them in the Clang release notes. Especially 
since this doesn't come with any balancing context (like 'you can now use 
template variables instead of instantiating a struct every time you check if 
two types are equal' ;) ) 


================
Comment at: clang/docs/ReleaseNotes.rst:46
+- The ``-fexperimental-new-pass-manager`` and ``-fno-legacy-pass-manager``
+  flags have been removed. These flags have been silently ignored since 15.
 
----------------
aaron.ballman wrote:
> I don't know if we want to standardize on `Clang-15` or `Clang 15`, etc. Feel 
> free to edit as you see fit.
Changed to Clang 15


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142578/new/

https://reviews.llvm.org/D142578

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to