dcoughlin added inline comments.
================
Comment at: test/Analysis/nullability.mm:114
@@ -112,1 +113,3 @@
+NSString *_Nonnull testNullReturnInTernaryOperator(int x) {
+ return x > 3 ? nil : [@"" stringByAppendingString:@""]; //
expected-warning {{Null is returned from a function that is expected to return
a non-null value}}
----------------
I think a better file for these two analyzer tests is
Analysis/nullability_nullonly.mm because they check for flows of nil to
_Nonnull and not _Nullable to _Nonnull. Also, you shouldn't need to add an
extra RUN line there.
Long-term these analyzer nullability test files need to be merged, but for this
change I think sticking the two added tests in nullability_nullonly.mm is the
best option.
https://reviews.llvm.org/D23236
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
