royjacobson added inline comments.
================ Comment at: clang/lib/AST/Type.cpp:2495 + // FIXME: We should merge this definition of triviality into + // CXXRecordDecl::isTrivial. Currently it computes the wrong thing. + return ClassDecl->hasTrivialDefaultConstructor() && ---------------- shafik wrote: > Will you follow-up this change by updating `CXXRecordDecl::isTrivial` as well > or is that a more difficult issue? I want to, but I need to check the call sites to make sure it won't change ABI or something. And I wanted a fix that I can safely backport :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143891/new/ https://reviews.llvm.org/D143891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
