phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:91
set(WINDOWS_LINK_FLAGS
- /vfsoverlay:${LLVM_VFSOVERLAY}
- # TODO: On Windows, linker is invoked by cmake instead of the clang-cl
driver,
- # so we have to manually set the libpath. We use clang-cl driver if we
can
- # and remove these libpath flags.
- -libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64"
- -libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/atlmfc/lib/x64"
- -libpath:"${LLVM_WINSYSROOT}/Windows Kits/10/Lib/10.0.19041.0/ucrt/x64"
- -libpath:"${LLVM_WINSYSROOT}/Windows Kits/10/Lib/10.0.19041.0/um/x64")
+ # TODO: lld-link has a bug that it cannot infer the machine type
+ # correctly when /winsysroot is set while Windows libraries search paths
----------------
Can you please file an LLVM issue for this and reference it here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143960/new/
https://reviews.llvm.org/D143960
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
