HazardyKnusperkeks added a comment. In D143870#4124057 <https://reviews.llvm.org/D143870#4124057>, @Febbe wrote:
> @HazardyKnusperkeks thank you for the review, I would add another option, but > I don't know a good name. I would propose a > > `boolean` `IncludeDeduplicateInAllBlocks` which defaults to zero. > > First an `Include`, to keep include-sorting related options together in the > documentation (sorted by name not by category) > `DeduplicateInAllBlocks` self explaining name. > > But `IncludeDeduplication` with the enum states `IDD_SameBlock`(default) and > IDD_ALL would also an option. > The latter has the advantage, that an expansion of this option would not > require the adjustment of tests. > > What's your preference? The `enum` is the better variant, I'd add the `Off`/`None` variant in the same breath. But the name has to be better, you don't need to start it with `Include`, since D138446 <https://reviews.llvm.org/D138446> we can link to other options and that should happen. So a more natural name would be `DeduplicateIncludeDirectives`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143870/new/ https://reviews.llvm.org/D143870 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
