phosek added a comment.

I missed this change so I apologize for late response, but can you elaborate on 
why this is needed? Clang first checks the name without architecture and if the 
file doesn't exist then it'll return the one with architecture unconditionally, 
see 
https://github.com/llvm/llvm-project/blob/d61a863050bb4afd22d08bbe53af1e24c0657aba/clang/lib/Driver/ToolChain.cpp#L545.
 Since there are no files inside 
https://github.com/llvm/llvm-project/tree/main/clang/test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/arm,
 it should always return the path with architecture as was the case for the 
previous version. `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` should play no role 
here since Clang tests are hermetic (as in they don't rely on runtimes being 
built).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143666/new/

https://reviews.llvm.org/D143666

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to