aaron.ballman added inline comments.
================
Comment at: test/clang-tidy/modernize-make-shared.cpp:109
@@ +108,3 @@
+ void create() {
+ auto ptr = std::shared_ptr<Private>(new Private(42));
+ }
----------------
Prazek wrote:
> aaron.ballman wrote:
> > Add comments explaining why make_shared is not correct. Also, please add a
> > case showing that protected constructors still get the proper fix applied.
> You mean I should also not warn when the constructor is protected? Make sense.
Correct, protected constructors should be handled like private constructors.
https://reviews.llvm.org/D23343
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
