thetruestblue added inline comments. Herald added a project: All.
================ Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 + ARCHS ${ASAN_SUPPORTED_ARCH} + OBJECT_LIBS RTAsan_static + CFLAGS ${ASAN_CFLAGS} ---------------- Can you explain the motivation here? RTAsan_static object library isn't built on Apple & Apple ASAN doesn't support static libraries. is there a reason why this was added to Apple that I'm missing? I don't believe this actually builds anything on Apple platforms since no OS is passed and in add_compiler_rt_runtime no libnames get set. Even the tests added are not-apple specific. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits