adalava added a comment. In D144232#4137367 <https://reviews.llvm.org/D144232#4137367>, @dim wrote:
> In D144232#4136787 <https://reviews.llvm.org/D144232#4136787>, @brad wrote: > >> I noticed this review. I have provided a more complete diff for review at >> D144321 <https://reviews.llvm.org/D144321>. > > Yeah I think that is probably the better option, hope @pkubaj and @adalava > agree with that? > > As Brad's version covers both FreeBSD and OpenBSD, and also updates a bunch > of unit tests, which this review appears to break (see the Unit Tests > https://reviews.llvm.org/harbormaster/unit/214420/). I agree with D144321 <https://reviews.llvm.org/D144321>, sorry for the late reply. @pkubaj and @brad , thanks for pushing it. I think D144232 <https://reviews.llvm.org/D144232> can be abandoned, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits