shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM, the modules failures is a previous known issue.
================
Comment at: clang/lib/AST/ExprConstant.cpp:8763
if (isLambdaCallOperator(Info.CurrentCall->Callee)) {
- // Ensure we actually have captured 'this'. (an error will have
- // been previously reported if not).
+ // Ensure we actually have captured 'this'. If something was wrong with
+ // 'this' capture, the error would have been previously reported.
----------------
Fznamznon wrote:
> shafik wrote:
> > It might be worth it to review all the examples here:
> > https://eel.is/c++draft/expr.prim.lambda
> >
> > and make sure the test we have actually covers all the scenarios. It looks
> > like we capture most of them but I have not gone over them fully.
> At least the ones about `this` capture seem to be working and covered. Not
> all of them have the same behavior as described though, for example on
> https://eel.is/c++draft/expr.prim.lambda#closure-6 clang complains about
> missing capture, though gcc agrees https://godbolt.org/z/hfxbEP5fW , so this
> is probably a bug in the example. Anyway I think this is a bit out of the
> scope of the patch.
I will dig into that discrepancy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144866/new/
https://reviews.llvm.org/D144866
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
