usama54321 added inline comments.
================ Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + ---------------- yln wrote: > zixuw wrote: > > dmaclach wrote: > > > yln wrote: > > > > This should work, right? > > > No.. darwin should fail with the `-static-libsan` flag. This is the test > > > that was failing and caused the rollback. > > I think @yln is suggesting using `REQUIRES: asan-static-runtime` instead of > > `XFAIL: darwin`. I wasn't aware of that conditional but yeah that should be > > better if it works. > I meant using `// REQUIRES: asan-static-runtime ` instead of `XFAIL: darwin` > since it seems that we already have a lit feature for it. I think UNSUPPORTED: darwin makes the most sense here. I don't think lit understands that REQUIRES: asan-static-runtime should result in skipping the test on Darwin as it does not know about this dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
