carlosgalvezp added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string:4-5 + +// For size_t +#include <string.h> + ---------------- Sorry I just noticed this - should we keep using the `__SYZE_TYPE__` macro that existed in the previous patch? The purpose of this header is to not include any standard header, and yet this is done in line 5 so it kinda defeats the purpose. I.e add the following under line 8: ``` typedef __SIZE_TYPE__ size_t ``` And then use that in line 17. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144216/new/ https://reviews.llvm.org/D144216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
