aaron.ballman added a comment. In D145704#4182341 <https://reviews.llvm.org/D145704#4182341>, @zahiraam wrote:
> In D145704#4182268 <https://reviews.llvm.org/D145704#4182268>, @aaron.ballman > wrote: > >> Thank you for working on this! Because this is fixing an ABI break, if we >> can land this in time for the release candidate I think we should try to add >> this to 16.0 to limit damage. CC @tstellar for his opinion. >> >> This doesn't seem to fully revert bbf0d1932a3c1be970ed8a580e51edf571b80fd5 >> <https://reviews.llvm.org/rGbbf0d1932a3c1be970ed8a580e51edf571b80fd5>; that >> commit changed `clang/lib/Sema/Sema.cpp` but this commit does not back those >> changes out. Is that intentional? > > Yes that makes sense because the changes in Sema were moved to > lib/lex/Preprocessor.cpp in this patch: https://reviews.llvm.org/D128814 Ah, thank you for the explanation, that makes sense. This variant comes with a .patch file added to the PR; that should be deleted in the next round. Aside from that, the changes LGTM, but I'd like to give precommit CI a chance to complete and some time for the folks impacted by the changes to weigh in before accepting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
