MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

`computeTargetTriple` has several users. You probably want to check all these 
code paths do not need `if (const Arg *A = 
Args.getLastArg(options::OPT_target))`.
For the uses in `BuildCompilation`, it seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145146/new/

https://reviews.llvm.org/D145146

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to