yaxunl added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup<HIPOpenMPOffloading>; ---------------- jdoerfert wrote: > mhalk wrote: > > jdoerfert wrote: > > > I doubt the ignored part very much. > > I just re-checked the LLVM IR of an example. > > With -x c++ there are __kmpc_target_(de)init calls; with -x hip there are > > none. > > https://godbolt.org/z/fhds46Pvc > > > > From my point of view, "effectively", target directives seem to have been > > ignored. > > Maybe this is a coincidence (there's definitely some uncertainty) or I am > > misinterpreting the IR. > > I would be glad if you could shed some light on this, if possible / you > > find the time to do so. > Line 512 in the HIP output: https://godbolt.org/z/n5s5jz7j9. If I remove --offload-arch for the C++ program, I got the same result as for HIP: https://godbolt.org/z/4TMzxdfj6 Does that mean we should emit the same error for C++ too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
