carlosgalvezp added a comment.
Looks good, just a small comment!
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/slicing.cpp:102
+
+struct BaseA {
+virtual ~BaseA() {}
----------------
Please briefly document this test case, i.e. why in this case this is not
considered slicing and the check should not warn. It would be good to also
mention the Github issue for traceability.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144206/new/
https://reviews.llvm.org/D144206
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
