PiotrZSL added a comment. "The dummy implementations of std::format and std::print require C++20, so it's easier to test them in a separate redundant-string-cstr-format.cpp check file. This also requires a small improvement to the basic_string_view implementation in the <string> dummy header.
With these changes, I was able to successfully run the readability-redundant-string-cstr check on a real source file that compiled successfully with what is destined to become GCC 13, and saw the expected:" You shouldn't explain your self why you choose this or other implementation, or pasting output from console. Commit message should contain only description about changes. All those explanation you can always put into review as comment. https://llvm.org/docs/DeveloperPolicy.html#commit-messages: "The body should be concise, but explanatory, including a complete reasoning. Unless it is required to understand the change, examples, code snippets and gory details should be left to bug comments, web review or the mailing list." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
