mikecrowe added a comment. In D145885#4187679 <https://reviews.llvm.org/D145885#4187679>, @PiotrZSL wrote:
> My only complain is documentation, changes in code and tests are correct. > Build failed mainly due to conflicts in previous change. > It should get green once prev patch will land, and this will be re-based. Thanks for the comments. I will address them. I've rebased this change on top of the rebase of the previous one. Maybe that will help. Git didn't report any conflicts when I rebased. > I strongly suggest using arc (less issues with patches). I have been using arc. I couldn't find a way to make it submit updates to more than one change at a time. I've done these two with `git checkout HEAD~1 ; arc diff ; git checkout mybranch; arc diff`. Is there a better way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
