craig.topper added inline comments.

================
Comment at: clang/lib/Driver/Driver.cpp:110
 
+extern void RISCVMarchHelp();
+
----------------
Can we declare this in RISCVISAInfo.h and include that here?


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:143
 
+void RISCVMarchHelp() {
+  auto Cmp = [](const RISCVSupportedExtension &a,
----------------
This function is not in the llvm namespace or a namespace nested under it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146054/new/

https://reviews.llvm.org/D146054

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to