efriedma added a comment.

Looks fine from a codegen perspective, assuming these are the semantics we want 
for -ffinite-math-only.



================
Comment at: clang/lib/CodeGen/CGCall.cpp:3052
+        AI->addAttrs(
+            llvm::AttrBuilder(getLLVMContext()).addNoFPClassAttr(Mask));
+      }
----------------
What cases does this cover that aren't already covered by the code in 
CodeGenModule::ConstructAttributeList?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145150/new/

https://reviews.llvm.org/D145150

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to