eddyz87 added a comment.

Hi @dfaust ,

Two head-ups, the following items turned out to be important when I tested 
using kernel BPF testsuite:

- in the final BTF, type tags have to precede CVR modifiers, e.g. TYPE_TAG 
'foo' -> CONST -> INT. Right now `pahole` does not do any reordering, so I 
ended up putting the type tag annotations on the DIE with outermost modifier. 
Will see if DI maintainers would be ok with this.
- CO-RE relocation entries have to point to the actual type, not type tag. For 
both field relocations and variable relocations (this is related to the next 
<https://reviews.llvm.org/D145891> patch in a stack).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143967/new/

https://reviews.llvm.org/D143967

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to