nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks! I have just one final nit, then please feel free to merge.
================
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60
+bool shouldPatchPlaceholder0(CodeCompletionResult::ResultKind ResultKind,
+ CXCursorKind CursorKind) {
----------------
nit: let's add a short comment to describe the function, such as:
```
// Determine whether the completion string should be patched
// to replace the last placeholder with $0
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145319/new/
https://reviews.llvm.org/D145319
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
