aaron.ballman added a comment. In D146187#4201271 <https://reviews.llvm.org/D146187#4201271>, @ChuanqiXu wrote:
>> Should we also be updating InitPreprocessor.cpp at the same time, for >> non-Windows targets? > > I didn't address this since we didn't do this before. (Defining feature macro > according to the targets). > > Also I feel it may be bad for windows users. Since currently the coroutines > on windows is not completely broken. It is still workable in some (or a lot?) > situations. It is just out of maintenance. The problem is, "out of maintenance" basically means "not supported" as far as users are concerned when they run into these bugs. I don't think we should claim to support the feature on a target where we know it has significant issues. I think in general we want feature testing macros to be treated as our signal to the user that we think something is complete, not that we think something is in progress but pretty usable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146187/new/ https://reviews.llvm.org/D146187 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
