vzakhari added inline comments.

================
Comment at: flang/include/flang/Tools/CLOptions.inc:238
+  pm.addPass(mlir::createCanonicalizerPass());
+  pm.addPass(hlfir::createLowerHLFIRIntrinsicsPass());
+  pm.addPass(hlfir::createBufferizeHLFIRPass());
----------------
I would imagine we may not want to optimize MATMUL(TRANSPOSE) into 
MATMUL_TRANSPOSE at O0.  What is the best way to control this?  We may either 
disable canonicalization or let `LowerHLFIRIntrinsicsPass` lower 
MATMUL_TRANSPOSE differently based on the optimization level.  Or is it always 
okay to implement it as a combined operation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146278/new/

https://reviews.llvm.org/D146278

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to