ADKaster added inline comments.

================
Comment at: clang-tools-extra/clangd/Headers.cpp:353
+  if (IsSystem ||
+      IncludeDelimiter == Config::IncludeDelimiterPolicy::AlwaysBrackets)
     Suggested = "<" + Suggested + ">";
----------------
I couldn't tell looking at other code in clangd whether it would be preferred 
to fetch the value from `Config::current()` here every time, or if having the 
option saved as a member variable of the IncludeInserter is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145843/new/

https://reviews.llvm.org/D145843

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to