erichkeane added a subscriber: asl. erichkeane added a comment. I've got the 1 concern with the mangling that I REALLY want one of our codegen owners to chime in on, otherwise this LGTM.
================ Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 + // argument. + // As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111. + auto *SNTTPE = cast<SubstNonTypeTemplateParmExpr>(E); ---------------- erichkeane wrote: > aaron.ballman wrote: > > We should get this nailed down. It was proposed in Nov 2020 and the issue > > is still open. CC @rjmccall > This definitely needs to happen. @rjmccall or @eli.friedman ^^ Any idea what > the actual mangling should be? This is still an open, and we need @rjmccall @eli.friedman or @asl to help out here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
