paulkirth marked an inline comment as done.
paulkirth added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58
 
   const auto *RVFI = MF.getInfo<RISCVMachineFunctionInfo>();
   if (RVFI->useSaveRestoreLibCalls(MF)) {
----------------
craig.topper wrote:
> paulkirth wrote:
> > craig.topper wrote:
> > > Can you add a FIXME here? Using x27 should hopefully remove this 
> > > restriction
> > I've added the FIXME, but do we just want to remove this now? or is there 
> > some issues or chang under review I can ref in the FIXME?
> We can remove it, but we should add a test for it.
That makes sense. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146463/new/

https://reviews.llvm.org/D146463

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to