carlosgalvezp marked an inline comment as done.
carlosgalvezp added inline comments.


================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:10
 
 TEST(TestCaseName, Illegal_TestName) {}
 // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: avoid using "_" in test name 
"Illegal_TestName" according to Googletest FAQ 
[google-readability-avoid-underscore-in-googletest-name]
----------------
PiotrZSL wrote:
> Be consistent and change all those TestCaseName into TestSuiteName.
Thanks, I missed these. Fixed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146713/new/

https://reviews.llvm.org/D146713

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to