mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land.
LGTM overall. I wondered if the modified test runs correctly on Windows (any test that touches paths is prone to break) but I see that it seems to have run successfully on both Windows and Linux in the premerge CI, so that's at least good. One minor question for the test. ================ Comment at: clang/test/Driver/mingw-sanitizers.c:2 +// RUN: touch %t.a +// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address -lcomponent %/t.a 2>&1 | FileCheck --check-prefixes=ASAN-ALL,ASAN-I686 -DINPUT=%/t.a %s +// RUN: %clang -target x86_64-windows-gnu %s -### -fsanitize=address -lcomponent %/t.a 2>&1 | FileCheck --check-prefixes=ASAN-ALL,ASAN-X86_64 -DINPUT=%/t.a %s ---------------- You're using `%/t.a` here while the file you touch is `%t.a` - I don't think I have seen `%/t` anywhere here before. I do see that lit seems to replace it though... Is this an intentional thing (what's the difference to `%t` though?) or is it a consistently copied typo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146908/new/ https://reviews.llvm.org/D146908 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
