aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Generally LGTM but had an additional test request.



================
Comment at: clang/test/AST/Interp/records.cpp:315
+      auto T = Test(Arr, Pos);
+      // End of scope, should destroy Test.
+    }
----------------
Would it make sense to give `Test` a constexpr destructor so that we can 
validate it's being called? e.g. https://godbolt.org/z/fhE7xzE4e


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147534/new/

https://reviews.llvm.org/D147534

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to