carlosgalvezp added a comment. In D147876#4256182 <https://reviews.llvm.org/D147876#4256182>, @njames93 wrote:
> In D147876#4256155 <https://reviews.llvm.org/D147876#4256155>, @carlosgalvezp > wrote: > >> Thanks for the review @njames93 ! Do you think it makes sense that we >> deprecate the string format, so that we only support the list format? To be >> fully removed in clang-tidy 19. Only for config file, for `--checks` we can >> still support string. This would allow us to get rid of all the code I wrote >> and simply pass the vector to `IO.mapOptional` :) > > Deprecating options from the config is a right pain to do and discourages > upgrading clang-tidy version with checked in configuration files Just because it's a pain it shouldn't stop us from working on it if we believe it's the right direction and will make the tool easier to use and maintain - I'm happy to do it :) > with checked in configuration files I'm not sure I understand what you mean by "checked in", could you clarify? If it's a pain for people to update their .clang-tidy files we could potentially create some Python script that does the change for them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147876/new/ https://reviews.llvm.org/D147876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
