aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment.
Adding the codegen code owners for their approval, but in general I think this is a good idea. ================ Comment at: clang/lib/CodeGen/ABIInfoImpl.h:33-52 +bool isAggregateTypeForABI(QualType T); + +llvm::Type *getVAListElementType(CodeGenFunction &CGF); + +CGCXXABI::RecordArgABI getRecordArgABI(const RecordType *RT, CGCXXABI &CXXABI); + +CGCXXABI::RecordArgABI getRecordArgABI(QualType T, CGCXXABI &CXXABI); ---------------- Because we're sort of elevating these from implementation details hidden in the .cpp to interfaces exposed via a header file, we should probably document these functions better (not needed as part of this change though). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147962/new/ https://reviews.llvm.org/D147962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
