mstorsjo added inline comments.

================
Comment at: clang/CMakeLists.txt:616
         -DDYLD_LIBRARY_PATH=${LLVM_LIBRARY_OUTPUT_INTDIR})
-    elseif(NOT WIN32)
+    elseif(WIN32)
+      add_dependencies(clang-bootstrap-deps llvm-lib)
----------------
I think I’d prefer to have the condition be `MSVC`, not `WIN32`, as we don’t 
want to use `llvm-lib` in the case of mingw.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148751/new/

https://reviews.llvm.org/D148751

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to