ilya-biryukov added inline comments.

================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:965
+    case CodeSynthesisContext::LambdaExpressionSubstitution:
+      // FIXME: add a note for lambdas.
       break;
----------------
erichkeane wrote:
> Would really like this note here, it shouldn't be too difficult, right? 
Ah, sorry, I added a comment here that I forgot to submit. The question is: 
could it be that we want to skip this note?

I wanted to double-check if folks find this note useful.
On one hand, this probably creates some noise as there will always be other 
notes that point into the location of a corresponding substitution location 
that contains the lambda.
On the other hand, since the lambda is not an immediate context, this may give 
hints to users on why SFINAE does not apply.

If you feel like the note is useful, I will follow up with an implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148802/new/

https://reviews.llvm.org/D148802

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to