tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Just emit `p != nullptr` for this.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D148981
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST/Interp/literals.cpp
===================================================================
--- clang/test/AST/Interp/literals.cpp
+++ clang/test/AST/Interp/literals.cpp
@@ -106,6 +106,19 @@
}
static_assert(gimme(5) == 5, "");
+namespace PointerToBool {
+
+ constexpr void *N = nullptr;
+ constexpr bool B = N;
+ static_assert(!B, "");
+ static_assert(!N, "");
+
+ constexpr float F = 1.0;
+ constexpr const float *FP = &F;
+ static_assert(FP, "");
+ static_assert(!!FP, "");
+}
+
namespace SizeOf {
constexpr int soint = sizeof(int);
constexpr int souint = sizeof(unsigned int);
Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp
===================================================================
--- clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -204,6 +204,17 @@
return this->emitCast(*FromT, *ToT, CE);
}
+ case CK_PointerToBoolean: {
+ // Just emit p != nullptr for this.
+ if (!this->visit(SubExpr))
+ return false;
+
+ if (!this->emitNullPtr(CE))
+ return false;
+
+ return this->emitNEPtr(CE);
+ }
+
case CK_ToVoid:
return discard(SubExpr);
Index: clang/test/AST/Interp/literals.cpp
===================================================================
--- clang/test/AST/Interp/literals.cpp
+++ clang/test/AST/Interp/literals.cpp
@@ -106,6 +106,19 @@
}
static_assert(gimme(5) == 5, "");
+namespace PointerToBool {
+
+ constexpr void *N = nullptr;
+ constexpr bool B = N;
+ static_assert(!B, "");
+ static_assert(!N, "");
+
+ constexpr float F = 1.0;
+ constexpr const float *FP = &F;
+ static_assert(FP, "");
+ static_assert(!!FP, "");
+}
+
namespace SizeOf {
constexpr int soint = sizeof(int);
constexpr int souint = sizeof(unsigned int);
Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp
===================================================================
--- clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -204,6 +204,17 @@
return this->emitCast(*FromT, *ToT, CE);
}
+ case CK_PointerToBoolean: {
+ // Just emit p != nullptr for this.
+ if (!this->visit(SubExpr))
+ return false;
+
+ if (!this->emitNullPtr(CE))
+ return false;
+
+ return this->emitNEPtr(CE);
+ }
+
case CK_ToVoid:
return discard(SubExpr);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
