cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land.
LGTM (modulo nitpicking comment) ================ Comment at: clang/test/Lexer/char-literal.cpp:49 +#ifndef __cplusplus +// expected-error@-2 {{universal character name refers to a control character}} +#endif ---------------- I think these tests would be clearer with a different verify tag rather than an ifdef, but it's kinda preexisting so feel free to ignore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149098/new/ https://reviews.llvm.org/D149098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits